impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Date Fri, 24 Mar 2017 23:00:41 GMT
Hello Internal Jenkins, Dan Hecht,

I'd like you to do a code review.  Please visit

to review the following change.

Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

* Copy gutil from Kudu
* Change includes to remove kudu/ prefix and KUDU_ guard prefix
* Minimal changes to gutil/CMakeLists.txt
* Include cherry-pick of 0c0b6f7 "Remove AMD Opteron Rev E workaround
  from atomicops".
* Overwrite changes from 92fafa "Use more efficient gutil implementation
  of Log2Ceiling" in favour of implementing them in Impala code only.

Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960

Remove AMD Opteron Rev E workaround from atomicops

Impala doesn't run on Opteron Rev E because those CPUs don't support
SSSE3.  So let's not pay the price of this cmp/branch on the atomics
path (which is used by our SpinLock, and I plan to make our Atomic class
use these functions in a future change).

Note that gperfutil also removed this RevE workaround since these CPUs
are getting old and apparently many kernels don't have the workaround

Let's call the init function for atomicops, even though it's basically a
no-op for 64-bit mode (since these features are always available). But
this future proofs the code a bit better.

Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05
Reviewed-by: Dan Hecht <>
Tested-by: Internal Jenkins
M be/src/gutil/CMakeLists.txt
D be/src/gutil/algorithm.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-powerpc.h
A be/src/gutil/atomicops-internals-tsan.h
M be/src/gutil/
M be/src/gutil/atomicops-internals-x86.h
D be/src/gutil/auxiliary/atomicops-internals-macosx.h
A be/src/gutil/bind.h
A be/src/gutil/bind.h.pump
A be/src/gutil/bind_helpers.h
A be/src/gutil/bind_internal.h
A be/src/gutil/bind_internal.h.pump
M be/src/gutil/
M be/src/gutil/bits.h
A be/src/gutil/callback.h
A be/src/gutil/callback.h.pump
A be/src/gutil/callback_forward.h
A be/src/gutil/
A be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
A be/src/gutil/
A be/src/gutil/cpu.h
M be/src/gutil/cycleclock-inl.h
R be/src/gutil/dynamic_annotations.c
M be/src/gutil/dynamic_annotations.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/
M be/src/gutil/hash/
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/integral_types.h
M be/src/gutil/linux_syscall_support.h
M be/src/gutil/logging-inl.h
M be/src/gutil/macros.h
M be/src/gutil/map-util.h
M be/src/gutil/
M be/src/gutil/mathlimits.h
M be/src/gutil/move.h
M be/src/gutil/
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
D be/src/gutil/proto/
D be/src/gutil/proto/types.pb.h
D be/src/gutil/proto/types.proto
A be/src/gutil/raw_scoped_refptr_mismatch_checker.h
A be/src/gutil/
A be/src/gutil/ref_counted.h
A be/src/gutil/
A be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
D be/src/gutil/sparsetable.h
M be/src/gutil/spinlock_win32-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/
M be/src/gutil/strings/
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/
M be/src/gutil/strings/
M be/src/gutil/strings/join.h
M be/src/gutil/strings/
M be/src/gutil/strings/
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/
M be/src/gutil/strings/strcat.h
A be/src/gutil/strings/
M be/src/gutil/strings/
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/
M be/src/gutil/strings/
M be/src/gutil/strings/
M be/src/gutil/strings/util.h
M be/src/gutil/
M be/src/gutil/sysinfo.h
M be/src/gutil/template_util.h
A be/src/gutil/threading/
A be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
R be/src/gutil/utf/rune.c
M be/src/gutil/
M be/src/gutil/walltime.h
90 files changed, 8,905 insertions(+), 3,853 deletions(-)

  git pull ssh:// refs/changes/76/6476/1
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3639dcf86c14778967c0079b8dbc222a4516cf05
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Internal Jenkins

View raw message