impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow
Date Mon, 20 Mar 2017 23:52:38 GMT
Taras Bobrovytsky has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6441

Change subject: IMPALA-5088: Fix heap buffer overflow
......................................................................

IMPALA-5088: Fix heap buffer overflow

In a recent patch, we introduced a change where we are incorrectly
copying a buffer. We are reading past the end of a buffer during the
copy. Even though we would never read the data that was copied from
past the end of the buffer, this could cause a crash if the allocation
is sitting on the edge of an unmapped area of memory. This also caused
the ASAN build to fail.

The issue is fixed by never accessing memory that is past the end of
the buffer

Change-Id: Ia68d69b35d53934e6f1aae2e1696503d17660ca2
---
M be/src/exprs/aggregate-functions-ir.cc
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/6441/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia68d69b35d53934e6f1aae2e1696503d17660ca2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message