impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5003: [DRAFT] Generic constant propagation in planner
Date Tue, 14 Mar 2017 17:12:17 GMT
Zach Amsden has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6389

Change subject: IMPALA-5003: [DRAFT] Generic constant propagation in planner
......................................................................

IMPALA-5003: [DRAFT] Generic constant propagation in planner

Rather than specialize the constant propagation framework to be specific
to a particular node type, create a generic framework for migrating
constants between conjuncts.  Right now it is still hard coded as being
embedded in HdfsScanNode, but the initial support appears to be working.

Testing: So far, manual.  Plan is to examine query plans once the full
support is working.  Right now, the substitution and folding appears to
work, but this doesn't make it to predicates in the query plan, nor does
it help select partitions, so some piece is definitely missing.

 explain select * from zparted where o_orderkey = 10 and partition_id =
o_orderkey % 100 + o_orderkey;

ConstantPropagator.java:85] Constant substitution from slot 2:
         partition_id = 10 % 100 + 10
ConstantPropagator.java:106] Constant folded result: partition_id = 20

 00:SCAN HDFS [default.zparted]
 partitions=100/100 files=100 size=23.00MB
 predicates: o_orderkey = 10, partition_id = o_orderkey % 100 + o_orderkey

Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/ConstantPropagator.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
3 files changed, 121 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/6389/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message