impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.
Date Tue, 07 Mar 2017 15:39:32 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6286

Change subject: IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.
......................................................................

IMPALA-5021: Fix count(*) remaining rows overflow in Parquet.

Zero-slot scans of Parquet files that have num_rows > MAX_INT32
in the footer metadata used to run forever due to an overflow when
calculating the remaining number of rows to process.

Testing:
- Added a regression test using a file with num_rows = 2*MAX_INT32.
- Locally ran test_scanners.py which succeeded.
- Private core/hdfs run succeeded

Change-Id: Ib9f8a6b83f8f621451d5977423ef81a6e4b124bd
---
M be/src/exec/hdfs-parquet-scanner.cc
M testdata/data/README
A testdata/data/huge_num_rows.parquet
M tests/query_test/test_scanners.py
4 files changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6286/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9f8a6b83f8f621451d5977423ef81a6e4b124bd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message