impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Pass build type to Impala LZO.
Date Fri, 31 Mar 2017 18:21:28 GMT
Alex Behm has submitted this change and it was merged.

Change subject: Pass build type to Impala LZO.
......................................................................


Pass build type to Impala LZO.

Before, the build type used for Impala LZO was always debug.
Now, the build type is passed from the Impala CMakeLists.txt.

This patch needs corresponding changes to Impala LZO.

Testing: I tested locally with these build types:
DEBUG, RELEASE, and ADDRESS_SANITIZER.

Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Reviewed-on: http://gerrit.cloudera.org:8080/6446
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Alex Behm <alex.behm@cloudera.com>
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Alex Behm: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message