impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Date Fri, 31 Mar 2017 16:58:17 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5140: improve docs building guidelines
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md
File docs/README.md:

PS5, Line 74:     * **To generate HTML output of the Impala SQL Reference, run the following
command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format html5
\
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_html.ditaval>
            :         ```
            : 
            :     * **To generate PDF output of the Impala SQL Reference, run the following
command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format pdf
\
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_pdf.ditaval>
            :         ```
> You'd have to tell me, since you are the initial committer of this file. On
Laurel was the original author. I'll add her to the review.


PS5, Line 111: y
             :    `/Users/<username>/.bash_profile`. Edit
> Done
It will be fine if you open a new terminal. I'd suggest assing "source" to these instructions
in step 1 so people who don't open a new terminal will get the right result.


-- 
To view, visit http://gerrit.cloudera.org:8080/6512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message