impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5140: improve docs building guidelines
Date Fri, 31 Mar 2017 16:29:57 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5140: improve docs building guidelines
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6512/5/docs/README.md
File docs/README.md:

PS5, Line 14: doc_prototype
master


PS5, Line 17: doc_prototype
master


PS5, Line 59: ./bin/dita
depends on where you put it


PS5, Line 74:     * **To generate HTML output of the Impala SQL Reference, run the following
command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format html5
\
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_html.ditaval>
            :         ```
            : 
            :     * **To generate PDF output of the Impala SQL Reference, run the following
command:**
            : 
            :         ```
            :         ./bin/dita -input <path_to_impala_sqlref.ditamap> -format pdf
\
            :           -output <path_to_build_output_directory> \
            :           -filter <path_to_impala_pdf.ditaval>
            :         ```
Why are these needed?


PS5, Line 111: add the
             :    following lines to the end of the file:
Then 'source' it.


-- 
To view, visit http://gerrit.cloudera.org:8080/6512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message