impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs
Date Thu, 30 Mar 2017 18:27:34 GMT
Henry Robinson has uploaded a new patch set (#3).

Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
......................................................................

IMPALA-4889: Use client sidecars for Thrift RPCs

This patch changes the way Thrift structures are serialized with
KRPC. Instead of serializing them to a byte stream, and then writing
that stream to a Protobuf object which is serialized again en route to
the wire, the Thrift objects are serialized to byte streams which are
then directly written to the wire as a 'sidecar'. This saves a copy and
serialization step both on the sender and receiver sides of the RPC.

Change-Id: I0fcc87c6b67aa167d70ae022663b14bc90261c95
---
M be/src/rpc/common.proto
M be/src/rpc/rpc-mgr-test.cc
M be/src/rpc/rpc.h
M be/src/rpc/thrift-util.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-test.cc
M be/src/statestore/statestore.cc
7 files changed, 125 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/6473/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fcc87c6b67aa167d70ae022663b14bc90261c95
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message