impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs
Date Thu, 30 Mar 2017 01:13:21 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6473/1/be/src/rpc/rpc.h
File be/src/rpc/rpc.h:

Line 169:     int idx = -1;
> I think it's technically undefined behavior not to initialize it here becau
what's undefined about it?
to me this looks like the function has undefined behavior in the idx==-1 case, from the perspective
of the caller, which i'd prefer to avoid.


Line 179:     RETURN_IF_ERROR(DeserializeThriftMsg(sidecar.data(), &len, true, resp));
how long is sidecar.data() valid?


-- 
To view, visit http://gerrit.cloudera.org:8080/6473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcc87c6b67aa167d70ae022663b14bc90261c95
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message