impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
Date Thu, 30 Mar 2017 00:20:14 GMT
Tim Armstrong has uploaded a new patch set (#3).

Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

BufferedBlockMgr had a number of interesting backend tests
that are still relevant to BufferPool. This commit copies
them across and adapts them to BufferPool. This should bring
the backend test coverage for BufferPool up to par with

Many tests weren't ported because they are not relevant or would
duplicate other tests:
* GetNewBlock* -> covered by PageCreation/BufferAllocation
* Pin -> covered by Pin
* Deletion/DeleteSingleBlocks -> all BufferPool tests cover deletion
* Close -> BufferPool doesn't have "cancellation"
* TransferBufferDuringWrite -> the API being tested is not present. Some
   of the deletion tests are the closest analogue.
* WriteCompleteWithCancelledRuntimeState -> not relevant, BufferPool
  doesn't reference RuntimeState.
* MultipleClients* -> we have many tests for the (very different)
  reservation mechanism
* ClientOversubscription -> oversubscription is not supported
* CreateDestroyMulti -> we don't support creation/destruction of
  buffer pools like this
* AllocationErrorHandling -> redundant with WriteErrorBlacklist

Change-Id: Ifb0221e8bea6f3b23b62d5094634d97562295ea3
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/
M be/src/runtime/bufferpool/
M be/src/runtime/bufferpool/buffer-pool.h
5 files changed, 819 insertions(+), 7 deletions(-)

  git pull ssh:// refs/changes/98/6498/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb0221e8bea6f3b23b62d5094634d97562295ea3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>

View raw message