impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db
Date Wed, 29 Mar 2017 23:00:01 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

lgtm, thanks for working through the alternatives.

http://gerrit.cloudera.org:8080/#/c/6503/4/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

PS4, Line 674:   
remove one space


PS4, Line 676: std
remove std::

Also can't hurt to have a one-line comment explaining that we need a mutable char array for
mkstemp.


-- 
To view, visit http://gerrit.cloudera.org:8080/6503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I490f741403ea2004bc51394aa1251577337b1e1d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message