impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()
Date Wed, 29 Mar 2017 19:55:45 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting()
......................................................................


Patch Set 3: Code-Review+2

This is fine, though it would be nice if memtracker/reservationtracker initialization happened
in a more controlled and systematic way (i.e. not registered into the tree until fully initialized).


But I'm not sure this really explains the crash you have in the jira.  Are you suspecting
that the compiler is reordering the construction of the reservation tracker and the write
of the scoped_ptr? Or that the scope_ptr read/write is being broken into multiple instructions?

-- 
To view, visit http://gerrit.cloudera.org:8080/6502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2434c952d97c46040e29fca2327c244dd30599d2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message