impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT
Date Tue, 28 Mar 2017 17:49:15 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-4318:  Kudu support for CREATE EXTERNAL TABLE AS SELECT
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6261/9//COMMIT_MSG
Commit Message:

Line 10: creating a new managed table, and importing an existing unmanaged
> "Managed" is a synonym for "internal", and the opposite of "external". So, 
Code is right, comment is very confused.  Let's try this:

    Create external table can be used for two different operations,
    creating a new table by selecting data from another, and importing
    an existing unmanaged external table.  Previously, for Kudu tables,
    it was only possible to issue CTAS for managed tables, and external
    tables were assumed to be imports of already existing data.  This
    change allows the creation of new, unmanaged (external) kudu tables
    from SELECT statements.

    In the catalog executor, we detect if a table creation is new by
    inferring that from the presence of column definitions, not by whether
    it is external / managed.  Front-end code is changed to allow this
    through the parser.  This means any attempts to specify table metadata
    for Kudu tables are now interpreted as a table creation.


-- 
To view, visit http://gerrit.cloudera.org:8080/6261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message