impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Date Tue, 28 Mar 2017 16:30:35 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................


Patch Set 7:

(4 comments)

Do you know if kudu actually pulled in a newer version of this code from upstream, and if
so, which version?

http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/bits.cc
File be/src/gutil/bits.cc:

Line 88: }
why did these move from the header?


http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/gscoped_ptr.h
File be/src/gutil/gscoped_ptr.h:

PS7, Line 112: kudu
is that intentional?


http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/port.h
File be/src/gutil/port.h:

PS7, Line 939: kudu
is that expected?


http://gerrit.cloudera.org:8080/#/c/5687/7/be/src/gutil/walltime.h
File be/src/gutil/walltime.h:

PS7, Line 83: 1e6
we had intentionally changed these so that we'd be using integer operations rather than floating
point. can we cherry pick that commit back over?


-- 
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message