impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Tue, 28 Mar 2017 04:39:57 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators

Patch Set 5: Code-Review+2

File be/src/service/

PS5, Line 180: node can coordinate queries.
maybe tighten this up:

"If true, this Impala daemon can accept and coordinate queries from clients. If false, this
daemon will only execute query fragments, and will refuse client connections.".
File be/src/service/impala-server.h:

Line 949: 
File be/src/service/

PS5, Line 461: if (!FLAGS_disable_admission_control) {
again, it seems better to check to see if admission_controller() != nullptr, or to have some
other check, than to share flags widely.
File be/src/util/

PS5, Line 192: Worker
nit: dunno how much we want to bikeshed this, but I prefer "Executor" to "Worker".

But either way, when is_coordinator == true, we should say "Coordinator + Worker", not just

PS5, Line 192: FLAGS_is_coordinator
it would be neater to do something like:


... if ExecEnv->impala_server() is ready at this point.
File www/root.tmpl:

Line 21:   <h2>Impala Server Mode</h2>
This template gets used for catalog and statestored as well. You need to check if impala_server_mode
is set.

I would also have something more concise, like:

<h2>Impala Server Mode: {{impala_server_mode}}</h2>

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message