impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
Date Mon, 27 Mar 2017 19:49:31 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/common/atomic.h
File be/src/common/atomic.h:

Line 104:     return base::subtle::Release_CompareAndSwap(&value_, old_val, new_val) ==
old_val;
> It looks like Barrier_CompareAndSwap was added by Dan to gutils in the belo
I reverted to the original (Dan's commit) just to be safe.


http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/util/time.h
File be/src/util/time.h:

PS6, Line 31: 1000000000ll
> nit: Maybe 1'000'000'000LL?
Tried it, but it confused my Emacs' cc-mode (which parsed it as an unterminated string). I
didn't spend much time trying to fix it.


PS6, Line 40: 1e9
> NANOS_PER_SEC?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message