impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
Date Mon, 27 Mar 2017 19:49:28 GMT
Hello Jim Apple, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5688

to look at the new patch set (#7).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
......................................................................

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors.

* Provide our own implementation of since-removed MonotonicNanos()
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Comment out non-compiling deprecated function definitions in numbers.h
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/exec/hash-table.inline.h
M be/src/gutil/macros.h
M be/src/gutil/strings/numbers.h
M be/src/runtime/bufferpool/suballocator.cc
M be/src/runtime/collection-value-builder.h
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/error-util.h
M be/src/util/time.h
M cmake_modules/kudu_cmake_fns.txt
10 files changed, 89 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5688/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message