impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Remove undefined behavior: left shift of negative values
Date Mon, 27 Mar 2017 18:34:33 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5031: Remove undefined behavior: left shift of negative values
......................................................................


Patch Set 1: Code-Review+1

Looks good, other than Tim's comments.

-- 
To view, visit http://gerrit.cloudera.org:8080/6491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d965c3950a878c0a41b374d51bbe2e5705b3360
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message