impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4701: make distcc work reliably with clang
Date Mon, 27 Mar 2017 18:14:40 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4701: make distcc work reliably with clang
......................................................................


Patch Set 1:

(4 comments)

Thank you for fixing this! I couldn't quite figure out how the variables in distcc.sh and
distcc_env.sh interact to configure distcc (on/off), ccache (on/off), and the compiler binary.
Maybe there's a way to make it more clear?

http://gerrit.cloudera.org:8080/#/c/6493/1/bin/distcc/distcc.sh
File bin/distcc/distcc.sh:

Line 31:   DIR=$(dirname "$0")
Maybe this should go in ""?


Line 50: CMD=
initialize to ccache?


Line 53:   CMD="distcc ccache"
Are we sure this is the right order of commands? Does this script support using ccache without
distcc? It looks odd to me. Would you mind adding a comment?


http://gerrit.cloudera.org:8080/#/c/6493/1/bin/distcc/distcc_env.sh
File bin/distcc/distcc_env.sh:

Line 74: : ${IMPALA_USE_DISTCC=}
I'm not sure I fully understand how to use this. Is this a variable that a developer would
set locally? Maybe IMPALA_DISTCC_LOCAL would be more clear? I don't feel strongly about the
name.


-- 
To view, visit http://gerrit.cloudera.org:8080/6493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message