impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
Date Mon, 27 Mar 2017 11:57:21 GMT
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6461

to look at the new patch set (#3).

Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
......................................................................

IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols

IMPALA-4226: Increase the thread count limit in the minidump stack
resolver. The old limit to 4096 is arbitrary and we are hitting it from
time to time.

To test this I ran minidump_stackwalk on a minidump with more than 4096
threads.

IMPALA-4227: Add basic support for dwz dwarf extension
The dwz tool [1] can be used to compress symbols that occur in multiple
object files by moving them into a shared object file. It introduces new
DWARF macros to reference to those symbols.

Breakpad currently does not support those macros, which can lead to
crashes.

This change makes breakpad ignore these symbols. Impala's binaries don't
share symbols so we are not losing functionality with this change.

To test this I ran dump_syms on a binary compiled on CentOS 7, which
uses DWZ for symbol compression.

[1] https://sourceware.org/git/?p=dwz.git;a=summary

Change-Id: I1bf83edd8cda037c31a842801ad1445f3fd4f71e
---
M buildall.sh
A source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
A source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Increase-maximum-number-of-threads-for-minidump_stac.patch
3 files changed, 120 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/61/6461/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1bf83edd8cda037c31a842801ad1445f3fd4f71e
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message