impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5115: Handle status from HdfsTableSink::WriteClusteredRowBatch
Date Sat, 25 Mar 2017 20:16:52 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5115: Handle status from HdfsTableSink::WriteClusteredRowBatch
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6486/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

Line 630:     RETURN_IF_ERROR(WriteClusteredRowBatch(state, batch));
> please also add WARN_UNUSED_RESULT to this function (and all others in hdfs
Done. I tried compiling with WARN_UNUSED_RESULT but without RETURN_IF_ERROR and gcc didn't
complain. Am I doing something wrong?


-- 
To view, visit http://gerrit.cloudera.org:8080/6486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6f5d87ae5e46d6019d9988011d3f2657e81ae15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message