impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
Date Fri, 24 Mar 2017 23:00:45 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/atomicops-internals-x86.h
File be/src/gutil/atomicops-internals-x86.h:

Line 46:   bool has_amd_lock_mb_bug;  // Processor has AMD memory-barrier bug; do lfence
> This code was deliberately removed in 
Thanks, reinstated.


http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/bits.h
File be/src/gutil/bits.h:

Line 141
> It looks you reverted:
Ok - I added those methods to BitUtil so that they're less likely to get overwritten in the
future. Those changes are in the 2/2 commit.


-- 
To view, visit http://gerrit.cloudera.org:8080/5687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message