impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
Date Fri, 24 Mar 2017 19:44:11 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6461/1/source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch
File source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch:

Line 19: +uint32_t MinidumpThreadList::max_threads_ = 32786;
> The value here is used on the system symbolizing the minidump, so it is ind
Ouch ok. I just realized you are talking about minidump stack resolver. Thanks for clarifying.


-- 
To view, visit http://gerrit.cloudera.org:8080/6461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf83edd8cda037c31a842801ad1445f3fd4f71e
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message