impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
Date Fri, 24 Mar 2017 19:04:12 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
......................................................................


Patch Set 2:

(2 comments)

Thanks for the reviews. I pushed a change upstream and picked it here, too.

http://gerrit.cloudera.org:8080/#/c/6461/1/source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch
File source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch:

Line 19
> Or can this be polled from ulimits? getrlimit(RLIMIT_NPROC,..) ..The number
The value here is used on the system symbolizing the minidump, so it is independent from the
one that wrote it.


Line 19
> I think in some cases on large clusters we've seen the thread count bumped 
After the discussion on breakpad-dev I think we can just set this to UINT_MAX. I changed this
in PS2 to the same patch I pushed upstream.


-- 
To view, visit http://gerrit.cloudera.org:8080/6461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf83edd8cda037c31a842801ad1445f3fd4f71e
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message