impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
Date Fri, 24 Mar 2017 17:24:12 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz compressed symbols
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6461/1/source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch
File source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Bump-max_threads-and-max_regions.patch:

Line 18: -uint32_t MinidumpThreadList::max_threads_ = 4096;
> Good point, I pinged the breakpad dev list and suggested doing this. In tha
That's fine by me, this is causing pain right now so we should just fix it. It's just nice
if we don't have to maintain our own patches long-term.


Line 19: +uint32_t MinidumpThreadList::max_threads_ = 32786;
> I haven't seen minidumps with more threads in the wild but I'm happy to bum
I think in some cases on large clusters we've seen the thread count bumped to several hundred
thousand to get around our Thrift limitations. Would it be hard to make it configurable via
a command line option or environment variable so we don't need to bump the value in the code
if we run into it again?


-- 
To view, visit http://gerrit.cloudera.org:8080/6461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf83edd8cda037c31a842801ad1445f3fd4f71e
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message