impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py
Date Thu, 23 Mar 2017 23:19:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
......................................................................


Patch Set 1:

(3 comments)

Change looks ok to me, just some minor comments on the interface

http://gerrit.cloudera.org:8080/#/c/6462/1/bin/dump_breakpad_symbols.py
File bin/dump_breakpad_symbols.py:

Line 115:   parser.add_argument('-r', '--rpm', '--deb', help="""RPM/DEB file containing the
binaries
Instead of adding a flag for every package type, should we just add a generic --pkg flag?
And keep --rpm for backwards compatibility.


Line 117:   parser.add_argument('-s', '--debuginfo_rpm', '--debuginfo_deb', help="""RPM/DEB
file
Same here - --symbol_pkg or similar?


Line 208:     logging.info('Extracting: %s' % pkg)
Mention the output directory? Might be helpful for debugging if it fails.


-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message