impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
Date Thu, 23 Mar 2017 19:03:04 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5688/4/be/src/common/atomic.h
File be/src/common/atomic.h:

Line 103:     base::subtle::MemoryBarrier();
Dan Hecht - you might want to take a look at this (Barrier_CompareAndSwap() has been removed
from gutil).


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message