impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.
Date Thu, 23 Mar 2017 18:59:00 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt
File CMakeLists.txt:

PS1, Line 294:     
> 2 spaces
Done


http://gerrit.cloudera.org:8080/#/c/5715/1/be/CMakeLists.txt
File be/CMakeLists.txt:

Line 150: # Kudu flags
> please add why these are specified or where they came from
Done


PS1, Line 292: maintenance_manager_proto
> can this be linked in kudu_util so it doesn't have to bleed in here? it's c
Fixed.


http://gerrit.cloudera.org:8080/#/c/5715/1/be/src/kudu/util/CMakeLists.txt
File be/src/kudu/util/CMakeLists.txt:

PS1, Line 185: #  version_info.cc TODO(KRPC): Consider re-adding
> why? remove the stub file if we don't compile it
I think removing the stub would be annoying for future updates to this directory - it would
just creep back in.


-- 
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message