impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Thu, 23 Mar 2017 18:28:27 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators

Patch Set 4:


Please consider adding something to the root web page (and to the log) saying if an Impala
is running in coordinator mode.
File be/src/service/

Line 1588:     LOG(WARNING) << "Failed to convert hostname " << hostname <<
" to IP address";
log status?

Line 1589:     return;
> do you know what the effect of this will be? it's a bit weird not to be abl
It means that the backend won't be available for execution. It's possible that FLAGS_hostname
is not set correctly, but also that there's a DNS outage or some other problem.

PS4, Line 1601: address
nit: descriptor

PS4, Line 1604: }
              :   if (status.ok()) {
else { 


PS4, Line 1909: NULL

PS4, Line 1931: NULL
File be/src/service/impala-server.h:

PS4, Line 438: In
nit: should be To, not In
File bin/

PS4, Line 40: 3
is there any way to make this default == the value of '-s'? If I run -s1 right now, won't
this fail the check on line 340? If not, I think removing that check is fine - doesn't matter
if we ask for more coordinators than we get.
File tests/custom_cluster/

Line 83:       client2.close()
can you add a check that the worker has not received the catalog metadata? GET /catalog or

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message