impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
Date Thu, 23 Mar 2017 00:57:18 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5958/3/testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
File testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test:

Line 67: select count(*) from functional_kudu.alltypesagg where id < 10 and float_col is
not null;
> shouldn't there only be 10 rows with id < 10?
Oddly enough, there are 11 rows with id < 10. There are two rows with id=0. I checked this
on alltypesagg on other encodings, and they have it too.


-- 
To view, visit http://gerrit.cloudera.org:8080/5958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c96fec8d41f77222879c0ffdd6940b168e47e65
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message