impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space
Date Wed, 22 Mar 2017 21:44:26 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 5:

Tim, mind taking a quick look at the latest patch?

The problem was that we are init'ing the timezonedb in the InitCommonRuntime(). One of the
tests relied on testing a custom local_library_dir was hitting a race in Catalog invoking
it, which is not required. It isn't required on the Catalog/SS. I moved it to ImpaladMain().

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message