impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Wed, 22 Mar 2017 18:33:28 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators
......................................................................


Patch Set 3:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

PS3, Line 180: if (FLAGS_disable_admission_control) LOG(INFO) << "Admission control
is disabled.";
             :     if (!FLAGS_disable_admission_control) {
> if (!FLAGS_disable_admission_control) {
Done


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/scheduling/admission-controller.h
File be/src/scheduling/admission-controller.h:

Line 200:   /// Registers the request queue topic.
> ... with the statestore.
Done


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/scheduling/scheduler-test-util.cc
File be/src/scheduling/scheduler-test-util.cc:

Line 457:   return scheduler_->ComputeScanRangeAssignment(*scheduler_->GetBackendConfig(),
0, nullptr,
> long line
Done


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 336:          std::vector<TTopicDelta>* topic_updates) {
> remove std::
Done


Line 343:           std::vector<TTopicDelta>* topic_updates) {
> remove std::
Done


PS3, Line 1489: Otherwise, this operation
              :     // is performed by the Scheduler.
> Can you just ensure that this is always done by this callback, and remove t
Done


Line 1579:   const std::string local_backend_id = exec_env_->subscriber()->id();
> remove std::
Done


Line 1589:     LOG(WARNING) << "Failed to convert hostname " << hostname <<
" to IP address";
> but keep going?
Done


Line 1592:   subscriber_topic_updates->push_back(TTopicDelta());
> emplace_back()
Done


Line 1595:   update.topic_entries.push_back(TTopicItem());
> emplace_back()
Done


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 436:   // backends. If not, add it and tell the statestore. Even though the same
> 'and tell the statestore'? doesn't something else do that part?
Done


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/testutil/in-process-servers.h
File be/src/testutil/in-process-servers.h:

PS3, Line 95: Not owned by this class;
            :   /// instead it's owned via shared_ptrs
> Ownership is shared now.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message