impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Wed, 22 Mar 2017 04:45:26 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators
......................................................................


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

Line 183:           request_pool_service_.get(), metrics_.get(), backend_address_));
> Hm, I am not sure this is possible. This is the ExecEnv constructor, is it 
never mind, i lost track of where i was.


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 336:          std::vector<TTopicDelta>* topic_updates) {
remove std::


Line 343:           std::vector<TTopicDelta>* topic_updates) {
remove std::


Line 1579:   const std::string local_backend_id = exec_env_->subscriber()->id();
remove std::


Line 1589:     LOG(WARNING) << "Failed to convert hostname " << hostname <<
" to IP address";
but keep going?


Line 1592:   subscriber_topic_updates->push_back(TTopicDelta());
emplace_back()


Line 1595:   update.topic_entries.push_back(TTopicItem());
emplace_back()


http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 436:   // backends. If not, add it and tell the statestore. Even though the same
'and tell the statestore'? doesn't something else do that part?

describe side effects (add to topic_updates and known_backends_).


-- 
To view, visit http://gerrit.cloudera.org:8080/6344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message