impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function
Date Wed, 22 Mar 2017 00:38:02 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-4848: Add WIDTH_BUCKET() function
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/6023/3//COMMIT_MSG
Commit Message:

PS3, Line 7: WIDTH_BUCKET()
> Nit that's bugging me: spelling :)
Done


http://gerrit.cloudera.org:8080/#/c/6023/3/be/src/exprs/math-functions-ir.cc
File be/src/exprs/math-functions-ir.cc:

Line 445: 
> use numeric_limits instead of INT32_MAX
Done


Line 456: 
> To simplify the handling of these strange cases, you might consider using D
Done


Line 460:     ctx->SetError("Overflow while bucket_width evaluation");
> UNLIKELY
Done


Line 461:     return IntVal::null();
> put parenthesis around the division to make the intended evaluation order c
This code has changed.


Line 462:   }
> Same comment as above for infinity. I don't think we can have infinity here
not needed with the decimalVal changes


-- 
To view, visit http://gerrit.cloudera.org:8080/6023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message