impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
Date Tue, 21 Mar 2017 20:31:51 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4643: [DOCS] Rewrite issues.cloudera.org URLs
......................................................................


Patch Set 1:

(2 comments)

I need to set up dita locally before I give you any pluses, but here are my comments so far.

http://gerrit.cloudera.org:8080/#/c/6452/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:

PS1, Line 316:   <keydef href="https://issues.apache.org/jira/browse/IMPALA-1" scope="external"
format="html" keys="IMPALA-1"/>
Unrelated to this review, but: This is wild! Is there a way to just have a macro so that these
things "just work" without all the explicit definitions?


http://gerrit.cloudera.org:8080/#/c/6452/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:

PS1, Line 50:      <xref href="https://issues.apache.org/" scope="external" format="html">issues.apache.org
JIRA tracker</xref>.
If you look https://issues.apache.org/ is a page that gives you links to various bug-tracking
sites for ASF. Maybe prefer https://issues.apache.org/jira/ when talking about the top-level
site?


-- 
To view, visit http://gerrit.cloudera.org:8080/6452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2725e4afedddedf8ba65963b217803f532dea
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message