impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Date Sat, 18 Mar 2017 03:51:22 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough
......................................................................


Patch Set 18:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5816/18/be/src/exec/union-node.h
File be/src/exec/union-node.h:

Line 61:   /// Index of the first non-passthrough child; i.e. a child that needs materializing
and
i.e. a child that needs materialization (remove the "and evaluating its exprs" part)


Line 62:   /// evaluating its exprs. When all children are materialized, this should be zero.
When
Shrink like this:

/// evaluating its exprs.
/// 0 when all children are materialized
/// 'children_.size()' when no children are materialized


http://gerrit.cloudera.org:8080/#/c/5816/18/fe/src/main/java/org/apache/impala/planner/UnionNode.java
File fe/src/main/java/org/apache/impala/planner/UnionNode.java:

Line 180:    * children come before the children that need to be materialized and evaluated.
Also
remove "and evaluated"


Line 181:    * reorders 'resultExprLists_'. This is done in order to simplify the implementation
in
Instead of 'This' be explicit since the reference could be misunderstood. Say "The children
are reordered to simplify ..."


http://gerrit.cloudera.org:8080/#/c/5816/18/tests/query_test/test_queries.py
File tests/query_test/test_queries.py:

Line 80:     query_string = ("select count(c) from ( "
Why not add this at the end of union.test? Seems odd to have a single naked test case without
a comment here.


-- 
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 18
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message