impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Date Sat, 18 Mar 2017 03:51:22 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough

Patch Set 18:

File be/src/exec/union-node.h:

Line 61:   /// Index of the first non-passthrough child; i.e. a child that needs materializing
i.e. a child that needs materialization (remove the "and evaluating its exprs" part)

Line 62:   /// evaluating its exprs. When all children are materialized, this should be zero.
Shrink like this:

/// evaluating its exprs.
/// 0 when all children are materialized
/// 'children_.size()' when no children are materialized
File fe/src/main/java/org/apache/impala/planner/

Line 180:    * children come before the children that need to be materialized and evaluated.
remove "and evaluated"

Line 181:    * reorders 'resultExprLists_'. This is done in order to simplify the implementation
Instead of 'This' be explicit since the reference could be misunderstood. Say "The children
are reordered to simplify ..."
File tests/query_test/

Line 80:     query_string = ("select count(c) from ( "
Why not add this at the end of union.test? Seems odd to have a single naked test case without
a comment here.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 18
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message