impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators
Date Fri, 17 Mar 2017 20:13:51 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators

Patch Set 1:

File be/src/scheduling/

Line 229: Status AdmissionController::Init(StatestoreSubscriber* subscriber) {
> Yeah, we need to at least execute the 'AddPoolUpdates' part of the callback
Done. Extracted the AdmissionController out of the Scheduler.

Line 230:   if (!FLAGS_is_coordinator) return Status::OK();
> This shouldn't even get called if is_coordinator is false. I think you shou
File be/src/service/

Line 1888:   if (be_port != 0 && be_server != NULL) {
> move this above line 1844, then return if this isn't a coordinator.
File be/src/service/impala-server.h:

Line 948: /// If beeswax_port != 0 (and fe_server != NULL), creates a ThriftServer exporting
> update comments with new semantics.
File bin/

Line 246:       args = "-is_coordinator=true %s" % (args)
> leave this out. it's the default, and we should make sure it actually works
File tests/custom_cluster/

Line 76:       self.execute_query_expect_success(client1, "drop database %s cascade" % db_name)
> why don't you add running a query against impalads[2] (and failing), and th

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message