impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)
Date Fri, 17 Mar 2017 17:05:35 GMT
Henry Robinson has submitted this change and it was merged.

Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)
......................................................................


IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

Upgrade gflags and glog together, glog is dependent on gflags.

Fix patch 0001 to install a message listener that no longer worked in
glog 0.3.4. Patched branch available for inspection at:

https://github.com/henryr/glog/commits/0.3.4-p2

Tested message listener reimplementation with Impala. glog unit tests
also pass.

Impala breakpad DCHECK test, which exercises the patched path, passes.

Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5
---
M buildall.sh
M source/gflags/build.sh
M source/glog/build.sh
A source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch
A source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch
5 files changed, 286 insertions(+), 10 deletions(-)

Approvals:
  Henry Robinson: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43bfe51a7b85f55f75e0bfe9f4eda1eea7856ff5
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message