impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior
Date Thu, 16 Mar 2017 20:56:39 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5041: Calling AuthManager::Init() more than once results in undefined
behavior
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6333/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Calling AuthManager::Init() more than once results in undefined behavior
Nit picking further: "Allow AuthManager::Init() to be called more than once"


http://gerrit.cloudera.org:8080/#/c/6333/2/be/src/rpc/authentication.h
File be/src/rpc/authentication.h:

PS2, Line 42: running
objects don't run, they have lifetime. So maybe "AuthManager should be treated like a singleton,
and only instantiated once.".


PS2, Line 43: a second time
more than once


-- 
To view, visit http://gerrit.cloudera.org:8080/6333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12cc210aa422f077446ea728ebf76921351417b0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message