impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT
Date Thu, 16 Mar 2017 17:39:04 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4318:  Kudu support for CREATE EXTERNAL TABLE AS SELECT
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6261/6/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

PS6, Line 360:     kudu_tbl_name = KuduTestSuite.to_kudu_table_name(unique_database, "foo2")
             :     assert kudu_client.table_exists(kudu_tbl_name)
             :     cursor.execute("SELECT * FROM %s.foo2" % (unique_database))
             :     assert len(cursor.fetchall()) == 1
             :     cursor.execute("DROP TABLE %s.foo2" % (unique_database))
             :     assert kudu_client.table_exists(kudu_tbl_name)
> Unless I'm mistaken, the entire unique_database gets dropped at the end of 
foo2 in kudu won't be deleted when you drop the database in impala though, that's the point
of the external table. if you take a look at your kudu I bet you'll see a bunch of foo2 tables
around (I think you can look at the master's web ui)


-- 
To view, visit http://gerrit.cloudera.org:8080/6261
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa82809a6c0c5e6386827314b7e5b520c1a6633
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message