impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables
Date Thu, 16 Mar 2017 17:35:42 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3742: partitions DMLs for Kudu tables
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-partitioner.h
File be/src/runtime/data-stream-partitioner.h:

PS8, Line 62: KuduStreamPartitioner
add some class-level comments here and to the HashPartitioner, e.g. call out that this one
calls into the Kudu API to perform the partitioning


PS8, Line 71: const T& cb
it sounds like you'll go back to the prev strategy (no lambda), but I'll mention this anyway:
this would deserve a good name and comment because it's not clear what this is, even reading
the code below


http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc
File be/src/runtime/data-stream-sender.cc:

Line 462:       default:
you can add a dcheck here to crash the process. this shouldn't happen unless we have a bug.


-- 
To view, visit http://gerrit.cloudera.org:8080/6037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10b3295159354888efcde3df76b0edb24161515
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message