impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo
Date Thu, 16 Mar 2017 09:35:58 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo
......................................................................


IMPALA-5077: add NUMA and current cpu to CpuInfo

NUMA info is found using the /sys filesystem.

The current CPU can be found using sched_getcpu(), which is supported
on all recent Linux kernels (unfortunately CentOS 5 shipped with an
older kernel, so we need a fallback).

Testing:
Confirmed that this built on a range of different Linux distros,
including CentOS 5, which is missing support for features like
sched_getcpu().

Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
Reviewed-on: http://gerrit.cloudera.org:8080/6402
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M CMakeLists.txt
M be/CMakeLists.txt
A be/src/common/.gitignore
M be/src/common/CMakeLists.txt
A be/src/common/config.h.in
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
7 files changed, 168 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message