impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo
Date Wed, 15 Mar 2017 23:52:51 GMT
Hello Jim Apple, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6402

to look at the new patch set (#6).

Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo
......................................................................

IMPALA-5077: add NUMA and current cpu to CpuInfo

NUMA info is found using the /sys filesystem.

The current CPU can be found using sched_getcpu(), which is supported
on all recent Linux kernels (unfortunately CentOS 5 shipped with an
older kernel, so we need a fallback).

Testing:
Confirmed that this built on a range of different Linux distros,
including CentOS 5, which is missing support for features like
sched_getcpu().

Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
---
M be/CMakeLists.txt
A be/src/common/.gitignore
M be/src/common/CMakeLists.txt
A be/src/common/config.h.in
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
6 files changed, 166 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/6402/6
-- 
To view, visit http://gerrit.cloudera.org:8080/6402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message