impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables
Date Wed, 15 Mar 2017 19:07:32 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3742: partitions DMLs for Kudu tables
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6037/7/be/src/runtime/data-stream-partitioner.cc
File be/src/runtime/data-stream-partitioner.cc:

PS7, Line 51:   KuduTableDescriptor* table_desc_ = static_cast<KuduTableDescriptor*>(table_desc);
            :   sp::shared_ptr<KuduClient> client_;
            :   RETURN_IF_ERROR(CreateKuduClient(table_desc_->kudu
> probably a codegen opportunity here for later, can you leave a TODO?
Done


http://gerrit.cloudera.org:8080/#/c/6037/7/be/src/runtime/data-stream-partitioner.h
File be/src/runtime/data-stream-partitioner.h:

PS7, Line 45:   // partition number as parameters.
            :   // TODO: make this cleaner without sacrifi
> I'm sorry if I wasn't clear when we spoke last, but I think it is still bet
Done


PS7, Line 63: 
> typo
Done


PS7, Line 87:   ++next_unknow
> rename to indicate used for R.R. only, e.g. next_unknown_partition_ or some
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10b3295159354888efcde3df76b0edb24161515
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message