impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo
Date Wed, 15 Mar 2017 17:44:26 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo

Patch Set 3:

File be/CMakeLists.txt:

PS3, Line 282:  
> nit: remove space?
File be/src/common/CMakeLists.txt:

> Does cmake automatically understand that compilation depends on this step?
The config file is generated during configuration (i.e. the "cmake ." step), so it will always
be generated before compilation. I think the only catch is that if you modify
without touching a CMakeLists.txt file (very unlikely) then it doesn't trigger regeneration
of the file.
File be/src/util/

PS3, Line 181: for (; dir_it != fs::directory_iterator(); ++dir_it) {
> directory_iterator doesn't work with ranged for syntax?
Doesn't look like it:
File be/src/util/cpu-info.h:

PS3, Line 87: hould
            :   /// be used by Impala.
> what does 'should be used' mean? Available for use?
I added a bit more explanation - it's usually just the number of online cores but there's
a --num_cores command line options.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message