impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo
Date Wed, 15 Mar 2017 17:44:26 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6402/3/be/CMakeLists.txt
File be/CMakeLists.txt:

PS3, Line 282:  
> nit: remove space?
Done


http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/common/CMakeLists.txt
File be/src/common/CMakeLists.txt:

PS3, Line 53: CONFIGURE_FILE
> Does cmake automatically understand that compilation depends on this step?
The config file is generated during configuration (i.e. the "cmake ." step), so it will always
be generated before compilation. I think the only catch is that if you modify config.h.in
without touching a CMakeLists.txt file (very unlikely) then it doesn't trigger regeneration
of the file.


http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

PS3, Line 181: for (; dir_it != fs::directory_iterator(); ++dir_it) {
> directory_iterator doesn't work with ranged for syntax?
Doesn't look like it: https://github.com/Beman/filesystem-proposal/issues/1


http://gerrit.cloudera.org:8080/#/c/6402/3/be/src/util/cpu-info.h
File be/src/util/cpu-info.h:

PS3, Line 87: hould
            :   /// be used by Impala.
> what does 'should be used' mean? Available for use?
I added a bit more explanation - it's usually just the number of online cores but there's
a --num_cores command line options.


-- 
To view, visit http://gerrit.cloudera.org:8080/6402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0525228a56bcf20c45f78ee1ba1d300c74cf4d05
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message