impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5003: [DRAFT] Generic constant propagation in planner
Date Tue, 14 Mar 2017 23:47:28 GMT
Zach Amsden has uploaded a new patch set (#3).

Change subject: IMPALA-5003: [DRAFT] Generic constant propagation in planner

IMPALA-5003: [DRAFT] Generic constant propagation in planner

Rather than specialize the constant propagation framework to be specific
to a particular node type, create a generic framework for migrating
constants between conjuncts.  Right now it is still hard coded as being
embedded in HdfsScanNode, and a few other places where it potentially
matters for partition selection.

Testing: So far, manual.  Plan is to examine query plans once the full
Substitution and folding work and are migrated into partition selection.

 explain select * from zparted where o_orderkey = 1 and partition_id =
o_orderkey % 100;] Constant substitution from slot 2:
         partition_id = 1 % 100] Constant folded result: partition_id = 1

 00:SCAN HDFS [default.zparted]
 partitions=1/100 files=100 size=23.00MB
 predicates: o_orderkey = 1

Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
M fe/src/main/java/org/apache/impala/analysis/
M fe/src/main/java/org/apache/impala/analysis/
A fe/src/main/java/org/apache/impala/analysis/
M fe/src/main/java/org/apache/impala/planner/
M fe/src/main/java/org/apache/impala/planner/
M fe/src/main/java/org/apache/impala/rewrite/
6 files changed, 162 insertions(+), 21 deletions(-)

  git pull ssh:// refs/changes/89/6389/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Zach Amsden <>

View raw message