impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode
Date Tue, 14 Mar 2017 21:49:26 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-4996: Single-threaded KuduScanNode
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6312/3/be/src/runtime/query-state.h
File be/src/runtime/query-state.h:

Line 21: #include <kudu/client/client.h>
> it would be really nice if we could avoid including the kudu header here. I
I'm looking into this. The sp::shared_ptr type comes from the KuduClientBuilder::Build call
in CreateKuduClient. I think it is not guaranteed to be safe for us to transfer something
from a shared_ptr to unique_ptr. There is no way for us to tell if this is the only shared_ptr
to that object.


-- 
To view, visit http://gerrit.cloudera.org:8080/6312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e4593300e376bc508b78acaea64ffdd2c73a67a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message