impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Date Tue, 14 Mar 2017 20:06:52 GMT
Laurel Hale has posted comments on this change.

Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Files build cleanly, content displays as expected in html & pdf, <keyref> only displays
in XML source. Only comment is can we eliminate references to 'cdh' in the <keyref>
token names?

http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS1, Line 1868: cdh
Just a thought--can we eliminate all references to cdh by changing the name of this <keyref>
token?


-- 
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message