impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5003: [DRAFT] Generic constant propagation in planner
Date Tue, 14 Mar 2017 17:37:37 GMT
Zach Amsden has uploaded a new patch set (#2).

Change subject: IMPALA-5003: [DRAFT] Generic constant propagation in planner
......................................................................

IMPALA-5003: [DRAFT] Generic constant propagation in planner

Rather than specialize the constant propagation framework to be specific
to a particular node type, create a generic framework for migrating
constants between conjuncts.  Right now it is still hard coded as being
embedded in HdfsScanNode, but the initial support appears to be working.

Testing: So far, manual.  Plan is to examine query plans once the full
Substitution and folding work and are migrated into partition selection.

 explain select * from zparted where o_orderkey = 1 and partition_id =
o_orderkey % 100;

ConstantPropagator.java:85] Constant substitution from slot 2:
         partition_id = 1 % 100
ConstantPropagator.java:106] Constant folded result: partition_id = 1

 00:SCAN HDFS [default.zparted]
 partitions=1/100 files=100 size=23.00MB
 predicates: o_orderkey = 1

Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/ConstantPropagator.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
3 files changed, 121 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/6389/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>

Mime
View raw message