impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Date Tue, 14 Mar 2017 03:46:47 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough
......................................................................


Patch Set 13:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.cc
File be/src/exec/union-node.cc:

Line 156:         // It is OK to close the child here because all RowBatches have already
been
> ... because all tuple data has been copied, and we will not be calling ...
changed the code significantly, This come was removed.


Line 174:     child_batch_.reset();
> move this before ++child_idx_ to have them clustered?
Code changed, this is not relevant any more.


http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.h
File be/src/exec/union-node.h:

Line 67:   /// Children that can be passed through, without evaluating and materializing their
> single line
Done


Line 109:   inline bool AtEos(int per_fragment_instance_idx) const {
> Maybe it's clearer to make GetNextPassThrough() not set eos, and instead ha
Changed the code completely.


Line 119:     DCHECK_LE(child_idx_, children_.size());
> Checking of the child_idx_ is dependent on the aller pattern of advancing t
Changed the code completely


-- 
To view, visit http://gerrit.cloudera.org:8080/5816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message